[PATCH] D51961: [objcopy] make objcopy follow program header standards

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 11 18:06:52 PDT 2018


jakehehrlich added a comment.

When you write your diff use `git diff -U<some big number> origin/master` so that the diff is relative to what's upstream not your last change locally. I think `git show` might be understood by fabricator as well but I'm not 100% sure.



================
Comment at: llvm/test/tools/llvm-objcopy/relocatable-phdr.test:16
+# CHECK:     ProgramHeaderEntrySize: 0
+# CHECK-NEXT:ProgramHeaderCount: 0
----------------
nit: add a space here


https://reviews.llvm.org/D51961





More information about the llvm-commits mailing list