[PATCH] D51550: Use alias analysis to check for real interference in cascade comparison

[Clement Courbet via Phabricator via llvm-commits]

courbet added inline comments.


================
Comment at: lib/Transforms/Scalar/MergeICmps.cpp:201
+
+    MemoryLocation LLoc = MemoryLocation::get(Lhs_.LoadI);
+    MemoryLocation RLoc = MemoryLocation::get(Rhs_.LoadI);
----------------
add a comment: "// Disallow stores that might alias the BCE operands"


================
Comment at: test/Transforms/MergeICmps/X86/alias-merge-blocks.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -mergeicmps -mtriple=x86_64-unknown-unknown -S | FileCheck %s --check-prefix=X86
----------------
christylee wrote:
> lebedev.ri wrote:
> > christylee wrote:
> > > lebedev.ri wrote:
> > > > Would be good to commit the test with current check-lines, so the diff is visible in the review.
> > > Hi @lebedev.ri !  Sorry I'm new to LLVM, what do you mean by "check-lines"?
> > In other words, i was suggesting to commit this test file (with the correct output from
> > `utils/update_test_checks.py`), so this differential would then show
> > how the code change affects the test.
> > 
> > check-lines - the lines with prefixes specified in `--check-prefix=` of `FileCheck`, in this case, `; X86`
> Is this what you mean, @lebedev.ri ?
I think what Roman means is: create another diff with just this file in it.  Then the current diff will show what your change does.


https://reviews.llvm.org/D51550