[PATCH] D49915: [IR] Add a boolean field in DILocation to know if a line must covered or not

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: include/llvm/IR/DebugInfoMetadata.h:1469
 
+  /// Check if the location corresponds to an implicit code.
+  bool isImplicitCode() const { return ImplicitCode; }
----------------
For the casual reader it will be entirely non-obvious what "implicit" code means. Can you add the explanation that you added at the top of the review to the doxygen comments (and perhaps to SourceLevelDebugging.rst ?


================
Comment at: lib/IR/AsmWriter.cpp:1756
   Printer.printMetadata("inlinedAt", DL->getRawInlinedAt());
+  Printer.printBool("isImplicitCode", DL->isImplicitCode());
   Out << ")";
----------------
It would be better to match the Parser and only print this if it deviates from the default value.


Repository:
  rL LLVM

https://reviews.llvm.org/D49915