[PATCH] D51879: [ASan] [MinGW] Avoid including headers for functions that will be redefined

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: lib/asan/asan_malloc_win.cc:28
 #define WIN32_LEAN_AND_MEAN
 #include <windows.h>
 
----------------
rnk wrote:
> How badly do we need this include? It looks like we only get it for a few typedefs like HANDLE, LPVOID, and some other stuff that we could avoid without too much work. This file is intentionally isolated to avoid these kinds of conflicts. Should we just isolate it from windows.h too?
That's probably a much less fragile approach - I'll see if I can make it build without it.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D51879