[PATCH] D51765: [WebAssembly] SIMD comparisons

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:348
+          (vec[1] (!cast<NI>(cond#"_"#vec[0])
+            (vec[0] V128:$lhs), (vec[0] V128:$rhs)))>;
+
----------------
1. Shouldn't "NE" be "ONE" here, according to the comments?
2. What kind of source pattern does this rule cover? I test your patch with commenting this part out, and all you tests succeed anyway.


Repository:
  rL LLVM

https://reviews.llvm.org/D51765