[llvm] r341856 - [lit] Disable shtest-timeout on Windows

Stella Stamenova via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 10 13:24:05 PDT 2018


Author: stella.stamenova
Date: Mon Sep 10 13:24:05 2018
New Revision: 341856

URL: http://llvm.org/viewvc/llvm-project?rev=341856&view=rev
Log:
[lit] Disable shtest-timeout on Windows

Summary: This is the only test that is still failing on Windows - or rather, it is expected to fail on the bots, but passes on the new bot that we're preparing causing a failure, so I'm going to disable it. Since the test has rarely, if ever, passed on the bots, this should have the same effect and it will unblock the creation of the new bot.

Reviewers: asmith, delcypher, zturner

Subscribers: stella.stamenova, llvm-commits

Differential Revision: https://reviews.llvm.org/D51871

Modified:
    llvm/trunk/utils/lit/tests/Inputs/shtest-timeout/lit.cfg
    llvm/trunk/utils/lit/tests/shtest-timeout.py

Modified: llvm/trunk/utils/lit/tests/Inputs/shtest-timeout/lit.cfg
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/Inputs/shtest-timeout/lit.cfg?rev=341856&r1=341855&r2=341856&view=diff
==============================================================================
--- llvm/trunk/utils/lit/tests/Inputs/shtest-timeout/lit.cfg (original)
+++ llvm/trunk/utils/lit/tests/Inputs/shtest-timeout/lit.cfg Mon Sep 10 13:24:05 2018
@@ -13,9 +13,7 @@ if shellType == '0':
     externalShell = False
 else:
     lit_config.note('Using external shell')
-    externalShell = (not sys.platform in ['win32'])
-    if not externalShell:
-        lit_config.note('External shell requested, but using internal shell')
+    externalShell = True
 
 configSetTimeout = lit_config.params.get('set_timeout', '0')
 

Modified: llvm/trunk/utils/lit/tests/shtest-timeout.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/shtest-timeout.py?rev=341856&r1=341855&r2=341856&view=diff
==============================================================================
--- llvm/trunk/utils/lit/tests/shtest-timeout.py (original)
+++ llvm/trunk/utils/lit/tests/shtest-timeout.py Mon Sep 10 13:24:05 2018
@@ -1,7 +1,7 @@
 # REQUIRES: python-psutil
 
-# PR33944
-# XFAIL: windows
+# llvm.org/PR33944
+# REQUIRES: nowindows
 
 # FIXME: This test is fragile because it relies on time which can
 # be affected by system performance. In particular we are currently




More information about the llvm-commits mailing list