[PATCH] D51810: [MIPS] Fix illegal type assert in single-float mode

[Simon Dardis via Phabricator via llvm-commits]

sdardis added inline comments.


================
Comment at: test/CodeGen/Mips/f32-to-i64-single-float.ll:1
+; RUN: llc -march=mips64el -mattr=+single-float < %s
+
----------------
ZirconiumX wrote:
> atanasyan wrote:
> > It looks like you miss any CHECK statements. I understand that without the fix this test case triggers assert, but it's better to express expected assembler code and check them.
> The expected assembly code is...complicated, and while I've been dipping my toes into MIPS because of the PS2, even on -O0, LLVM inlines the conversion rather than producing something convenient to check like a library call. I'm not sure what exactly to check for, because my MIPS assembly knowledge isn't perfect.
You can use update_llc_checks.py to generate the expected / current assembly result rather than hand-crafting CHECK lines. You'll need to change the -march=mips64el to -mtriple=mips64el-mti-linux-gnu .


Repository:
  rL LLVM

https://reviews.llvm.org/D51810