[PATCH] D51848: [RegisterCoalescer] Fixup "Fixed inconsistent followCopyChain with subreg"

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 10 08:38:17 PDT 2018


qcolombet added a comment.

Hi Tim,

Same comments as https://reviews.llvm.org/D51574.
The change looks good but the test case if not specific enough. We shouldn't require asserts and at least, we should check we coalesce the live-ranges in a sensible way.

Cheers,
-Quentin


Repository:
  rL LLVM

https://reviews.llvm.org/D51848





More information about the llvm-commits mailing list