[PATCH] D51777: [IndVars] Set Changed if sinkUnusedInvariants changes IR. PR38863

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added a comment.

In https://reviews.llvm.org/D51777#1228447, @skatkov wrote:

> I see that IndVarsSimplify uses class field Changed. You propose to use Changed as return value. I just want to see the same approach through the whole IndVars...
>
> Do you plan to modify other pieces to return Changed or may be it makes sense to re-use the class field approach here as well?
>  What do you think?


I agree that having Changed as a field is bizzare. It makes a lot of confusion regarding the proper place where it should be set. I plan to rework it to make it a local variable, but I haven't look into how easy it's gonna be.


https://reviews.llvm.org/D51777