[PATCH] D51810: [MIPS] Fix illegal type assert in single-float mode

Simon Atanasyan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 9 14:08:55 PDT 2018


atanasyan added inline comments.


================
Comment at: test/CodeGen/Mips/f32-to-i64-single-float.ll:1
+; RUN: llc -march=mips64el -mattr=+single-float < %s
+
----------------
It looks like you miss any CHECK statements. I understand that without the fix this test case triggers assert, but it's better to express expected assembler code and check them.


Repository:
  rL LLVM

https://reviews.llvm.org/D51810





More information about the llvm-commits mailing list