[llvm] r341716 - [benchmark] Re-enable benchmarks on all platforms including Windows

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 7 14:47:00 PDT 2018


Author: rnk
Date: Fri Sep  7 14:47:00 2018
New Revision: 341716

URL: http://llvm.org/viewvc/llvm-project?rev=341716&view=rev
Log:
[benchmark] Re-enable benchmarks on all platforms including Windows

The assertion in MCCodeView.cpp was resolved in r340878.

This reverts both r340905 and r340836, making benchmarks build by
default everywhere.

Modified:
    llvm/trunk/CMakeLists.txt
    llvm/trunk/docs/CMake.rst

Modified: llvm/trunk/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/CMakeLists.txt?rev=341716&r1=341715&r2=341716&view=diff
==============================================================================
--- llvm/trunk/CMakeLists.txt (original)
+++ llvm/trunk/CMakeLists.txt Fri Sep  7 14:47:00 2018
@@ -495,12 +495,7 @@ option(LLVM_INCLUDE_GO_TESTS "Include th
 
 option(LLVM_BUILD_BENCHMARKS "Add LLVM benchmark targets to the list of default
 targets. If OFF, benchmarks still could be built using Benchmarks target." OFF)
-option(LLVM_INCLUDE_BENCHMARKS "Generate benchmark targets. If OFF, benchmarks
-can't be built. This is set to OFF for Windows." ON)
-
-if (CMAKE_HOST_SYSTEM_NAME STREQUAL "Windows")
-  set(LLVM_INCLUDE_BENCHMARKS OFF)
-endif()
+option(LLVM_INCLUDE_BENCHMARKS "Generate benchmark targets. If OFF, benchmarks can't be built." ON)
 
 option (LLVM_BUILD_DOCS "Build the llvm documentation." OFF)
 option (LLVM_INCLUDE_DOCS "Generate build targets for llvm documentation." ON)

Modified: llvm/trunk/docs/CMake.rst
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/docs/CMake.rst?rev=341716&r1=341715&r2=341716&view=diff
==============================================================================
--- llvm/trunk/docs/CMake.rst (original)
+++ llvm/trunk/docs/CMake.rst Fri Sep  7 14:47:00 2018
@@ -254,8 +254,7 @@ LLVM-specific variables
   Adds benchmarks to the list of default targets. Defaults to OFF.
 
 **LLVM_INCLUDE_BENCHMARKS**:BOOL
-  Generate build targets for the LLVM benchmarks. Defaults to ON, but is set
-  to OFF on Windows.
+  Generate build targets for the LLVM benchmarks. Defaults to ON.
 
 **LLVM_APPEND_VC_REV**:BOOL
   Embed version control revision info (svn revision number or Git revision id).




More information about the llvm-commits mailing list