[PATCH] D51740: [PGO][CHR] Small cleanup.

Hiroshi Yamauchi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 7 10:00:02 PDT 2018


yamauchi added inline comments.


================
Comment at: lib/Transforms/Instrumentation/ControlHeightReduction.cpp:426
 
+static inline
+raw_ostream LLVM_ATTRIBUTE_UNUSED &operator<<(raw_ostream &OS,
----------------
yamauchi wrote:
> davidxl wrote:
> > Why this change? Is anonymous namespace not enough?
> It may be ok, https://llvm.org/docs/CodingStandards.html#anonymous-namespaces seems to prefer a static function.
> 
> 
I meant to say "but" after "ok," before "https://llvm.org...." in the above comment.


Repository:
  rL LLVM

https://reviews.llvm.org/D51740





More information about the llvm-commits mailing list