[PATCH] D51744: [WIP] Early ThinLTOLayer2 prototype

Stefan Gränitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 7 09:35:33 PDT 2018


sgraenitz added inline comments.


================
Comment at: lib/ExecutionEngine/Orc/ThinLTOLayer.cpp:362
+  // TODO Would it be good to preserve the order?
+  std::sort(JDs.begin(), JDs.end());
+  JDs.erase(std::unique(JDs.begin(), JDs.end()), JDs.end());
----------------
mgrang wrote:
> Please use llvm::sort instead of std::sort. See https://llvm.org/docs/CodingStandards.html#beware-of-non-deterministic-sorting-order-of-equal-elements
Ok changed that. (Although dups will be removed in the below line and their order is of no relevance.)


Repository:
  rL LLVM

https://reviews.llvm.org/D51744





More information about the llvm-commits mailing list