[PATCH] D50560: [LLD] Enable Visual Studio compatible diagnostics.

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 7 06:29:35 PDT 2018


arichardson added inline comments.


================
Comment at: ELF/Relocations.cpp:636
 
-  error(Msg);
+  Diag->error(Msg + referencedBy(SymLoc));
   return true;
----------------
This would have been useful for me too when I added new error messages to our fork of LLD. I just ended up copy-pasting the string constants from other files in lld.
I like this since it will ensure consistent warning message formats everywhere.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D50560





More information about the llvm-commits mailing list