[PATCH] D51770: [IndVars] Set Changed when we delete dead instructions. PR38855

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added inline comments.


================
Comment at: lib/Transforms/Scalar/IndVarSimplify.cpp:2502
   // loop may be sunk below the loop to reduce register pressure.
   sinkUnusedInvariants(L);
 
----------------
mkazantsev wrote:
> skatkov wrote:
> > should it be fixed as well? And other places?
> Maybe. It needs comprehensive analysis. I need to revisit any single place separately, let's not do it in this patch. It is to address a particular crash, however I agree that we might take a closer look into how `Changed` is sad.
> 
Filed https://bugs.llvm.org/show_bug.cgi?id=38863 to follow-up.


https://reviews.llvm.org/D51770