[PATCH] D51723: [XRay] Add a BlockVerifier visitor for FDR Records

[Dean Michael Berris via Phabricator via llvm-commits]

dberris marked an inline comment as done.
dberris added inline comments.


================
Comment at: llvm/lib/XRay/BlockVerifier.cpp:62
+          {State::Unknown,
+           {mask(State::BufferExtents) | mask(State::NewBuffer)}},
+
----------------
eizan wrote:
> I presume State::WallClockTime has an underlying value of 3, so won't 3<<1 also pass (1 | 2)<<1 ?
We're turning `0001` into `1000` when we call `mask(State::WallclockTime)`. Note that the operation in `mask(...)` is `1uLL << N` where N is the underlying value for the enum.


https://reviews.llvm.org/D51723