[PATCH] D51561: [CMake] Add support for unittests that have input files

[via llvm-commits]

LGTM. That works. Thanks!

Matthew

From: Zachary Turner [mailto:zturner at google.com]
Sent: Thursday, September 6, 2018 3:02 PM
To: Chris Bieneman
Cc: reviews+D51561+public+3ae47e1528dc299e at reviews.llvm.org; chandlerc at gmail.com; rnk at google.com; Voss, Matthew; maskray at google.com; mgorny at gentoo.org; hiraditya at msn.com; llvm-commits at lists.llvm.org; llvm at inglorion.net
Subject: Re: [PATCH] D51561: [CMake] Add support for unittests that have input files

Hopefully fixed in r341590.  Can you give it a try Matthew?

On Thu, Sep 6, 2018 at 2:55 PM Zachary Turner <zturner at google.com<mailto:zturner at google.com>> wrote:
Yes I figured this out, but then I have to fix up the runtime function that finds the file.  Because in VS configurations it will be in dir(Argv0).parent() and in non-vs configurations it will be in dir(Argv0).

On Thu, Sep 6, 2018 at 2:29 PM Chris Bieneman <chris.bieneman at me.com<mailto:chris.bieneman at me.com>> wrote:
The `configure_file` command shouldn't have the `${CMAKE_CFG_INTDIR}` in the middle. configure_file is done at config time, not build time, and it only runs once, so you don't want it to be per-configuration.

-Chris



On Sep 6, 2018, at 2:28 PM, Zachary Turner <zturner at google.com<mailto:zturner at google.com>> wrote:

Let me look at it.  I have VS installed so I can repro it.  Gimme about 30 minutes and I'll update with a path forward.

On Thu, Sep 6, 2018 at 2:20 PM Matthew Voss via Phabricator <reviews at reviews.llvm.org<mailto:reviews at reviews.llvm.org>> wrote:
ormris added a comment.

This is causing issues for our Visual Studio builds. CMake doesn't know which configuration will be used at build time, so we end up with "llvm.srcdir.txt" placed in directory called "$(Configuration)". Any thoughts on a fix?


Repository:
  rL LLVM

https://reviews.llvm.org/D51561



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180906/beb4e590/attachment.html>