[compiler-rt] r341440 - [hwasan] fix colored output

[David Blaikie via llvm-commits]

I generally feel like if it's worth fixing, it's worth testing. Similar
sort of fixes in Clang would generally be tested.

At least assuming general testing of sanitizer output isn't too laborious.

On Wed, Sep 5, 2018 at 4:31 PM Kostya Serebryany <kcc at google.com> wrote:

> On Wed, Sep 5, 2018 at 3:59 PM David Blaikie <dblaikie at gmail.com> wrote:
>
>> no way to force colours on? (might be handy for users using 'tee' or
>> similar - I think that's the case for clang diagnostics & so some of the
>> colouring is tested there/that way)
>>
>
> err, actually, we already have a flag (*SAN_OTIONS=color=always)
> still not sure if tests are worth the effort here.
>
>
>
>>
>> On Wed, Sep 5, 2018 at 3:53 PM Kostya Serebryany <kcc at google.com> wrote:
>>
>>> not easy: the colors are stripped when the output is a file (not a
>>> console).
>>> and may be not worth it (we don't have tests for colors for other
>>> sanitizers)
>>>
>>>
>>> On Wed, Sep 5, 2018 at 3:17 PM David Blaikie <dblaikie at gmail.com> wrote:
>>>
>>>> Test case?
>>>>
>>>> On Tue, Sep 4, 2018 at 6:28 PM Kostya Serebryany via llvm-commits <
>>>> llvm-commits at lists.llvm.org> wrote:
>>>>
>>>>> Author: kcc
>>>>> Date: Tue Sep  4 18:27:48 2018
>>>>> New Revision: 341440
>>>>>
>>>>> URL: http://llvm.org/viewvc/llvm-project?rev=341440&view=rev
>>>>> Log:
>>>>> [hwasan] fix colored output
>>>>>
>>>>> Modified:
>>>>>     compiler-rt/trunk/lib/hwasan/hwasan_report.cc
>>>>>
>>>>> Modified: compiler-rt/trunk/lib/hwasan/hwasan_report.cc
>>>>> URL:
>>>>> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/hwasan/hwasan_report.cc?rev=341440&r1=341439&r2=341440&view=diff
>>>>>
>>>>> ==============================================================================
>>>>> --- compiler-rt/trunk/lib/hwasan/hwasan_report.cc (original)
>>>>> +++ compiler-rt/trunk/lib/hwasan/hwasan_report.cc Tue Sep  4 18:27:48
>>>>> 2018
>>>>> @@ -135,6 +135,7 @@ void PrintAddressDescription(uptr tagged
>>>>>        Printf("%s", d.Location());
>>>>>        Printf("Address %p is located in stack of thread T%zd\n",
>>>>> untagged_addr,
>>>>>               t->unique_id());
>>>>> +      Printf("%s", d.Default());
>>>>>        t->Announce();
>>>>>
>>>>>        num_descriptions_printed++;
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> llvm-commits mailing list
>>>>> llvm-commits at lists.llvm.org
>>>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>>>
>>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180906/f4cf010e/attachment.html>