[PATCH] D49678: [llvm-objcopy] Adding support for compressed DWARF debug sections.

Puyan Lotfi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 6 15:18:06 PDT 2018


plotfi added a comment.

In https://reviews.llvm.org/D49678#1222836, @chandlerc wrote:

> Reverted temporarily in r341360 to unbreak my build and the aarch64 build bot. Let me know if I can help with the investigation in any way.


@jakehehrlich @chandlerc I need help reproing this. I finally got an aarch64 setup up and running and the tests pass. I don't understand why this would fail.

I do think it may be possible that the Chdr copy should be changed to:

  Elf_Chdr_Impl<ELFT> Chdr;
  Chdr.ch_type = ELF::ELFCOMPRESS_ZLIB;
  Chdr.ch_size = Sec.DecompressedSize;
  Chdr.ch_addralign = Sec.DecompressedAlign;
  memcpy(Buf, &Chdr, sizeof(Chdr));

to avoid any alignment bugs.

PL


Repository:
  rL LLVM

https://reviews.llvm.org/D49678





More information about the llvm-commits mailing list