[PATCH] D51561: [CMake] Add support for unittests that have input files

Chris Bieneman via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 6 14:29:27 PDT 2018


The `configure_file` command shouldn't have the `${CMAKE_CFG_INTDIR}` in the middle. configure_file is done at config time, not build time, and it only runs once, so you don't want it to be per-configuration.

-Chris

> On Sep 6, 2018, at 2:28 PM, Zachary Turner <zturner at google.com> wrote:
> 
> Let me look at it.  I have VS installed so I can repro it.  Gimme about 30 minutes and I'll update with a path forward.
> 
> On Thu, Sep 6, 2018 at 2:20 PM Matthew Voss via Phabricator <reviews at reviews.llvm.org <mailto:reviews at reviews.llvm.org>> wrote:
> ormris added a comment.
> 
> This is causing issues for our Visual Studio builds. CMake doesn't know which configuration will be used at build time, so we end up with "llvm.srcdir.txt" placed in directory called "$(Configuration)". Any thoughts on a fix?
> 
> 
> Repository:
>   rL LLVM
> 
> https://reviews.llvm.org/D51561 <https://reviews.llvm.org/D51561>
> 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180906/d831d584/attachment.html>


More information about the llvm-commits mailing list