[PATCH] D47858: [New PM] Introducing PassInstrumentation framework

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 6 11:38:25 PDT 2018


fedor.sergeev added inline comments.


================
Comment at: include/llvm/IR/PassInstrumentation.h:199
+private:
+  mutable PassExecutionCounter PC;
+
----------------
philip.pfaffe wrote:
> Is `mutable` necessary now?
Yes, it is necessary since runBeforePass - the only callback that increments PC - is const.
I'm not sure it buys us anything, so I can get rid of both const there and mutable here.
I dont care actually :)


Repository:
  rL LLVM

https://reviews.llvm.org/D47858





More information about the llvm-commits mailing list