[PATCH] D51433: [InstCombine] enhance vector demanded elements to look at a vector select condition operand

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 6 06:55:30 PDT 2018


spatel marked 2 inline comments as done.
spatel added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp:1267
+      if (Value *V = SimplifyDemandedVectorElts(I->getOperand(0), DemandedElts,
+                                                UndefElts, Depth + 1)) {
+        I->setOperand(0, V);
----------------
RKSimon wrote:
> Won't using UndefElts interfere with the Left/Right cases below?
Yes, good catch. Not sure how to expose that in a test, but I'll fix the code in the next rev.


https://reviews.llvm.org/D51433





More information about the llvm-commits mailing list