[PATCH] D51145: make copyFMF consistent with AnyDefined for detection of any FMF flag set to true

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 5 17:11:09 PDT 2018


aemerson added a comment.

In https://reviews.llvm.org/D51145#1224873, @spatel wrote:

> In https://reviews.llvm.org/D51145#1223770, @mcberg2017 wrote:
>
> > I added one more non fmf instruction and there is room to add others if needed.
>
>
> There's also discussion about the definition of FPMathOperator and the relation to FMF here:
>  https://bugs.llvm.org/show_bug.cgi?id=38086
>  https://reviews.llvm.org/D51646


Thanks.

I think this approach makes sense, given that the langref only defines a restricted few instructions to carry fast-math flags, not the entire group that the current FPMathOperator allows. But I'd like someone else to check it over. @hfinkel does this look reasonable?


https://reviews.llvm.org/D51145





More information about the llvm-commits mailing list