[PATCH] D51646: DAG: Preserve FMF when creating fminnum/fmaxnum

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 5 17:08:39 PDT 2018


aemerson added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:1088-1091
+#if 0
       else
         Node->intersectFlagsWith(IncomingFlags);
+#endif
----------------
arsenm wrote:
> I forgot about this problem. I don't understand why it was trying to strip these flags in the first place, but it will always do it
Maybe this is related, we've seen on D51145 that if the FPMathOperator doesn't actually have any FP flags (like insert/extractelements) then the incoming flags result in stripping.


https://reviews.llvm.org/D51646





More information about the llvm-commits mailing list