[PATCH] D51709: [lit] Correctly expand globs relative to their intended directory.

[Graydon Hoare via Phabricator via llvm-commits]

graydon added a comment.

For context, the motivation here is a somewhat subtle testcase over in swift driver land in which we need to construct an argv for the driver that is not longer than kern.maxarg, but that will be transformed into such an over-long argv when composed with an absolute output directory and passed to a frontend. This test has been flaky on CI because we were globbing the input to the driver (under a "cd ... && ...") and lit was sticking the absolute path of the testsuite-on-the-CI-machine on the front of all the globbed inputs. Sometimes this meant the input argv to the driver would overflow, other times not; depends on which CI host and subdir it's running inside of. Obviously not great.

See https://github.com/apple/swift/pull/19149 for current workaround on swift side. I'm also fixing it here so that nobody has to hunt this particular family of errors down again.


Repository:
  rL LLVM

https://reviews.llvm.org/D51709