[PATCH] D48792: [ARM] Set execute-only flags in .text.

Ivan Lozano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 5 15:41:01 PDT 2018


ivanlozano added inline comments.


================
Comment at: lib/MC/MCObjectStreamer.cpp:500
+  MCSection *Sec = getCurrentSectionOnly();
+  Sec->setHasData(true);
 }
----------------
echristo wrote:
> Given that the only target that cares about hasData is the ARM backend you could probably override this there and only worry about setting it within that backend?
Chatted offline with echristo and decided this might add a bit of complexity to the patch (we'd need to define an ARM-specific MCSectionELF to sink the entire hasData flag into the ARM backend). So I'm adding a note to the HasData flag that it's only used by the ARM backend right now.


https://reviews.llvm.org/D48792





More information about the llvm-commits mailing list