[PATCH] D51648: [UBSan] Partially fix `test/ubsan/TestCases/Misc/log-path_test.cc` so that it can run on devices.

George Karpenkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 5 11:11:27 PDT 2018


george.karpenkov added a comment.

@filcab The script is in `iossim` folder, so it's specifically for iOS simulators. Arbitrary devices and their support is irrelevant for this change.



================
Comment at: test/sanitizer_common/ios_commands/iossim_run.py:21
+  rm_args = []
+  for arg in sys.argv[2:]:
+    if '*' in arg or '?' in arg:
----------------
@dliew actually, stepping back a bit here, why can't we just do

```
subprocess.call(sys.argv[1:])
```

?

whatever shell expansions are there, they would be already expanded by the shell at that point.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D51648





More information about the llvm-commits mailing list