[PATCH] D51677: [benchmark] Fix 32-bit build failure

Kirill Bobyrev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 5 03:18:32 PDT 2018


kbobyrev created this revision.
kbobyrev added a reviewer: lebedev.ri.

This patch applies changes proposed in https://github.com/google/benchmark/pull/667

Tim Northover pointed out that benchmark build might be broken on 32-bit macOS. This pull request by Roman Lebedev (lebedev.ri) resolves the issue.


https://reviews.llvm.org/D51677

Files:
  llvm/utils/benchmark/README.LLVM
  llvm/utils/benchmark/src/sysinfo.cc


Index: llvm/utils/benchmark/src/sysinfo.cc
===================================================================
--- llvm/utils/benchmark/src/sysinfo.cc
+++ llvm/utils/benchmark/src/sysinfo.cc
@@ -288,7 +288,7 @@
     std::string name;
     std::string type;
     int level;
-    size_t num_sharing;
+    uint64_t num_sharing;
   } Cases[] = {{"hw.l1dcachesize", "Data", 1, CacheCounts[1]},
                {"hw.l1icachesize", "Instruction", 1, CacheCounts[1]},
                {"hw.l2cachesize", "Unified", 2, CacheCounts[2]},
Index: llvm/utils/benchmark/README.LLVM
===================================================================
--- llvm/utils/benchmark/README.LLVM
+++ llvm/utils/benchmark/README.LLVM
@@ -13,3 +13,5 @@
   is applied on top of the v1.4.1 to silence compiler warnings
 * https://github.com/google/benchmark/commit/505be96ab23056580a3a2315abba048f4428b04e
   is applied to comply with the LLVM's required CMake version
+* https://github.com/google/benchmark/pull/667 is applied to fix 32-bit build
+  failure on macOS


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51677.164001.patch
Type: text/x-patch
Size: 1039 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180905/3ae99988/attachment.bin>


More information about the llvm-commits mailing list