[PATCH] D51616: [ExplicitGuards][NFC] API for explicit guards recognition

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 4 22:09:37 PDT 2018


fedor.sergeev added inline comments.


================
Comment at: include/llvm/Analysis/GuardUtils.h:22
 
-/// Returns true iff \p U has semantics of a guard.
-bool isGuard(const User *U);
+/// Returns true of we can prove that execution will reach a call of an
+/// llvm.experimental.deopt intrinsic and memory will not be modified before
----------------
*if* we can prove


================
Comment at: include/llvm/Analysis/GuardUtils.h:25
+/// that under assumption that we enter the basic block \p BB.
+bool alwaysGoesToReExecutableDeoptBlock(const BasicBlock *BB);
+
----------------
Hmm... perhaps its coffee time, but I cant draw a line between the function name and its functionality.
"Re"-executable?


https://reviews.llvm.org/D51616





More information about the llvm-commits mailing list