[PATCH] D51660: [llvm-strip] Support stripping multiple input files

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht added inline comments.


================
Comment at: test/tools/llvm-objcopy/strip-multiple-files.test:9
+# Stripped objects are different from original.
+# RUN: not cmp %t.o %t.1.o
+# RUN: not cmp %t.o %t.2.o
----------------
alexshap wrote:
> not sure if these checks are particularly useful, 
> i'd probably reorganize  and simplify (and, actually, speed up) this test a little bit:
> 1. run llvm-strip on one .o
> 2. run llvm-readobj on the output and verify that the output is correct (via FileCheck)
> 3. run llvm-strip on 3 .o and verify that the outputs are correct (via cmp ) (compare them with the result of (2))
> What would  you say to this approach ? 
Thanks, that makes it look nicer than what I have here.

I left in the case where we just have two files, since I want to make sure that edge case is tested (e.g. "llvm-strip a b" isn't somehow interpreted as "llvm-strip a -o b")


Repository:
  rL LLVM

https://reviews.llvm.org/D51660