[PATCH] D51571: [Xray] Darwin providing defined value for weak symbols to fix linkage issue

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 4 16:02:08 PDT 2018


dberris accepted this revision.
dberris added a comment.
This revision is now accepted and ready to land.

We have two options here:

- Revert the change in clang that enables XRay for the front-end.

- Put this in to stop the buildbot failures.

I'm fine with either, as long as there's an understanding that this will be fixed by running the tests in macOS is going to be done appropriately.

I suspect @devnexen you're willing to do the investigation into how to fix this appropriately for Darwin?


https://reviews.llvm.org/D51571





More information about the llvm-commits mailing list