[PATCH] D51447: [WebAssembly] clang-format (NFC)

Dan Gohman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 4 14:53:06 PDT 2018


sunfish added a comment.

On one hand, clang-format -style=LLVM really isn't the one exclusive formatting style of LLVM. CodingStandards.rst repeatedly emphasizes this. When we're working in LLVM outside of wasm-specific code, we need to respect the existing code formatting which isn't always clang-formatted, or locally reformat it as needed when making changes, so it's not a bad idea for us to get used to working that way anyway. And we accept patches that aren't clang-formatted.

At the same time, it's just formatting, and the changes here are pretty minor overall, and the svn blame issue is ultimately just an occasional minor nuisance, so if you feel strongly about this, feel free to land it.


Repository:
  rL LLVM

https://reviews.llvm.org/D51447





More information about the llvm-commits mailing list