[PATCH] D51463: Fix a couple of mangling canonicalizer corner case bugs.

Erik Pilkington via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 4 11:45:25 PDT 2018


erik.pilkington accepted this revision.
erik.pilkington added a comment.
This revision is now accepted and ready to land.

Huh. I think there may be some more (many?) similar bugs to this. Possible testcase: `_Z1fI1SEiS0_T_` and `_Z1fI1SEiS0_S0_`. I think these will be considered equivalent to the canonicalizer because their representation is structurally equivalent, but they are in fact distinct. I think we can fix this with extra indirection. Finding and fixing these as-needed is probably fine, but something to keep in mind.

Otherwise, LGTM!


Repository:
  rL LLVM

https://reviews.llvm.org/D51463





More information about the llvm-commits mailing list