[PATCH] D51603: [CMake] Provide a custom target to install LLVM libraries

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 4 11:10:55 PDT 2018


phosek marked an inline comment as done.
phosek added inline comments.


================
Comment at: llvm/CMakeLists.txt:986
   endif()
+
+  # Custom target to install all libraries.
----------------
beanz wrote:
> Should probably wrap this in `if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY)` because that variable gates generating the `install-${lib}` targets, so it will explode with missing targets if `LLVM_INSTALL_TOOLCHAIN_ONLY=On`.
It's already in the `if(NOT LLVM_INSTALL_TOOLCHAIN_ONLY)` block that starts at line 949.


Repository:
  rL LLVM

https://reviews.llvm.org/D51603





More information about the llvm-commits mailing list