[PATCH] D50820: [VPlan] Implement initial vector code generation support for simple outer loops.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

I just tried to build your patch, and it triggers

  lib/Transforms/Vectorize/LoopVectorize.cpp:1288: bool llvm::LoopVectorizationCostModel::isScalarAfterVectorization(llvm::Instruction*, unsigned int) const: Assertion `ScalarsPerVF != Scalars.end() && "Scalar values are not calculated for VF"' failed.

for  the vplan tests.



================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:2800
 void InnerLoopVectorizer::emitMemRuntimeChecks(Loop *L, BasicBlock *Bypass) {
+  // VPlan-native path does not do any analysis for runtime checks currently.
+  if (EnableVPlanNativePath)
----------------
sguggill wrote:
> fhahn wrote:
> > Should we ever hit this code path in the vplan native path at the moment? If not, I would turn it into an assert.
> We do hit this code in vplan native path and later hit a seg fault as getLAI returns NULL. 
Right! I think for now it is better to exit early here then,


Repository:
  rL LLVM

https://reviews.llvm.org/D50820