[PATCH] D47858: [New PM] Introducing PassInstrumentation framework

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 3 13:36:16 PDT 2018


fedor.sergeev added inline comments.


================
Comment at: include/llvm/IR/PassManager.h:709
+  PassInstrumentation<IRUnitT>
+  getPassInstrumentation(IRUnitT &IR, std::tuple<ArgTs...> Args,
+                         llvm::index_sequence<Ns...>) {
----------------
philip.pfaffe wrote:
> Are you ever actually calling this, except through the indirection above?
Any suggestions on how to simplify it?
This unpacker thing is the only way I figured to get Ns == sizeof(ExtraArgTs) and not sizeof(ArgTs).


Repository:
  rL LLVM

https://reviews.llvm.org/D47858





More information about the llvm-commits mailing list