[PATCH] D51577: MidnightBSD support in LLVM

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added a comment.

Adding some more context, there are a few remixes of FreeBSD such as TruOS, GhostBSD, DesktopBSD etc... and all of them are custom reconfiguration of defaults and they keep self recognition to `__FreeBSD__`. MidnightBSD is similar, it's a remix of FreeBSD with GNUSTEP. For some reason the project decided to fork the FreeBSD distribution entirely, however over the years there were no[t so many] distinct features to recognize this OS as a distinct version of BSD ( https://github.com/freebsd/freebsd/blob/master/share/misc/bsd-family-tree ).

I know that this is harsh, but this is the current track of patches for MidnightBSD, that they are regularly rejected in projects. Unless the MidnightBSD community can attach a buildbot in the building farm, I recommend to reject this code and recommend to MidnightBSD to fix self-recognition... and probably rebase to recent FreeBSD to get MIPS support also in sanitizers.


Repository:
  rL LLVM

https://reviews.llvm.org/D51577