[PATCH] D50222: [CodeGen] [SelectionDAG] More efficient code for X % C == 0 (UREM case)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 3 04:03:15 PDT 2018


RKSimon added a comment.

Please add uniform and non-uniform vector test cases as well.



================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:3782
+
+  // TODO: Add non-uniform constant support
+  ConstantSDNode *Divisor = isConstOrConstSplat(REMNode->getOperand(1));
----------------
It should be trivial for you to add non-uniform vector support in this patch, following the patterns I did for the other divsion-by-constant builders. 


Repository:
  rL LLVM

https://reviews.llvm.org/D50222





More information about the llvm-commits mailing list