[llvm] r341271 - AMDGPU/GlobalISel: Define instruction mapping for G_SELECT

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 31 19:41:19 PDT 2018


Author: tstellar
Date: Fri Aug 31 19:41:19 2018
New Revision: 341271

URL: http://llvm.org/viewvc/llvm-project?rev=341271&view=rev
Log:
AMDGPU/GlobalISel: Define instruction mapping for G_SELECT

Reviewers: arsenm

Reviewed By: arsenm

Subscribers: kzhuravl, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, llvm-commits, t-tye

Differential Revision: https://reviews.llvm.org/D49737

Added:
    llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/regbankselect-select.mir
Modified:
    llvm/trunk/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp

Modified: llvm/trunk/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp?rev=341271&r1=341270&r2=341271&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp (original)
+++ llvm/trunk/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp Fri Aug 31 19:41:19 2018
@@ -170,6 +170,42 @@ AMDGPURegisterBankInfo::getInstrAlternat
 
     return AltMappings;
   }
+  case TargetOpcode::G_SELECT: {
+    unsigned Size = getSizeInBits(MI.getOperand(0).getReg(), MRI, *TRI);
+    const InstructionMapping &SSMapping = getInstructionMapping(1, 1,
+      getOperandsMapping({AMDGPU::getValueMapping(AMDGPU::SGPRRegBankID, Size),
+                          AMDGPU::getValueMapping(AMDGPU::SCCRegBankID, 1),
+                          AMDGPU::getValueMapping(AMDGPU::SGPRRegBankID, Size),
+                          AMDGPU::getValueMapping(AMDGPU::SGPRRegBankID, Size)}),
+      4); // Num Operands
+    AltMappings.push_back(&SSMapping);
+
+    const InstructionMapping &SVMapping = getInstructionMapping(2, 1,
+      getOperandsMapping({AMDGPU::getValueMapping(AMDGPU::VGPRRegBankID, Size),
+                          AMDGPU::getValueMapping(AMDGPU::SGPRRegBankID, 1),
+                          AMDGPU::getValueMapping(AMDGPU::SGPRRegBankID, Size),
+                          AMDGPU::getValueMapping(AMDGPU::VGPRRegBankID, Size)}),
+      4); // Num Operands
+    AltMappings.push_back(&SVMapping);
+
+    const InstructionMapping &VSMapping = getInstructionMapping(2, 1,
+      getOperandsMapping({AMDGPU::getValueMapping(AMDGPU::VGPRRegBankID, Size),
+                          AMDGPU::getValueMapping(AMDGPU::SGPRRegBankID, 1),
+                          AMDGPU::getValueMapping(AMDGPU::VGPRRegBankID, Size),
+                          AMDGPU::getValueMapping(AMDGPU::SGPRRegBankID, Size)}),
+      4); // Num Operands
+    AltMappings.push_back(&VSMapping);
+
+    const InstructionMapping &VVMapping = getInstructionMapping(2, 1,
+      getOperandsMapping({AMDGPU::getValueMapping(AMDGPU::VGPRRegBankID, Size),
+                          AMDGPU::getValueMapping(AMDGPU::SGPRRegBankID, 1),
+                          AMDGPU::getValueMapping(AMDGPU::VGPRRegBankID, Size),
+                          AMDGPU::getValueMapping(AMDGPU::VGPRRegBankID, Size)}),
+      4); // Num Operands
+    AltMappings.push_back(&VVMapping);
+
+    return AltMappings;
+  }
   default:
     break;
   }
@@ -542,6 +578,24 @@ AMDGPURegisterBankInfo::getInstrMapping(
     }
     break;
   }
+  case AMDGPU::G_SELECT: {
+    unsigned Size = MRI.getType(MI.getOperand(0).getReg()).getSizeInBits();
+    unsigned Op1Bank = getRegBankID(MI.getOperand(1).getReg(), MRI, *TRI,
+                                    AMDGPU::SGPRRegBankID);
+    unsigned Op2Bank = getRegBankID(MI.getOperand(2).getReg(), MRI, *TRI);
+    unsigned Op3Bank = getRegBankID(MI.getOperand(3).getReg(), MRI, *TRI);
+    bool SGPRSrcs = Op1Bank == AMDGPU::SCCRegBankID &&
+                    Op2Bank == AMDGPU::SGPRRegBankID &&
+                    Op3Bank == AMDGPU::SGPRRegBankID;
+    unsigned Bank = SGPRSrcs ? AMDGPU::SGPRRegBankID : AMDGPU::VGPRRegBankID;
+    Op1Bank = SGPRSrcs ? AMDGPU::SCCRegBankID : AMDGPU::SGPRRegBankID;
+    OpdsMapping[0] = AMDGPU::getValueMapping(Bank, Size);
+    OpdsMapping[1] = AMDGPU::getValueMapping(Op1Bank, 1);
+    OpdsMapping[2] = AMDGPU::getValueMapping(Bank, Size);
+    OpdsMapping[3] = AMDGPU::getValueMapping(Bank, Size);
+    break;
+  }
+
   case AMDGPU::G_LOAD:
     return getInstrMappingForLoad(MI);
   }

Added: llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/regbankselect-select.mir
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/regbankselect-select.mir?rev=341271&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/regbankselect-select.mir (added)
+++ llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/regbankselect-select.mir Fri Aug 31 19:41:19 2018
@@ -0,0 +1,214 @@
+# RUN: llc -march=amdgcn -mcpu=fiji -run-pass=regbankselect -global-isel %s -verify-machineinstrs -o - -regbankselect-fast | FileCheck --check-prefixes=GCN,FAST %s
+# RUN: llc -march=amdgcn -mcpu=fiji -run-pass=regbankselect -global-isel %s -verify-machineinstrs -o - -regbankselect-greedy | FileCheck --check-prefixes=GCN,GREEDY %s
+
+# REQUIRES: global-isel
+
+--- |
+  define void @select_sss() { ret void }
+  define void @select_ssv() { ret void }
+  define void @select_svs() { ret void }
+  define void @select_svv() { ret void }
+  define void @select_vss() { ret void }
+  define void @select_vsv() { ret void }
+  define void @select_vvs() { ret void }
+  define void @select_vvv() { ret void }
+...
+
+---
+name: select_sss
+legalized: true
+
+# GCN-LABEL: name: select_sss
+# GCN: [[SGPR0:%[0-9]+]]:sgpr(s32) = COPY $sgpr0
+# GCN: [[SGPR1:%[0-9]+]]:sgpr(s32) = COPY $sgpr1
+# GCN: [[SGPR2:%[0-9]+]]:sgpr(s32) = COPY $sgpr2
+# GCN: [[SGPR3:%[0-9]+]]:sgpr(s32) = COPY $sgpr3
+# GCN: [[SCC:%[0-9]+]]:scc(s1) = G_ICMP intpred(ne), [[SGPR0]](s32), [[SGPR1]]
+# GCN: {{%[0-9]+}}:sgpr(s32) = G_SELECT [[SCC]](s1), [[SGPR2]], [[SGPR3]]
+
+body: |
+  bb.0:
+    liveins: $sgpr0, $sgpr1, $sgpr2, $sgpr3
+    %0:_(s32) = COPY $sgpr0
+    %1:_(s32) = COPY $sgpr1
+    %2:_(s32) = COPY $sgpr2
+    %3:_(s32) = COPY $sgpr3
+    %4:_(s1) = G_ICMP intpred(ne), %0, %1
+    %5:_(s32) = G_SELECT %4, %2, %3
+...
+
+---
+name: select_ssv
+legalized: true
+
+# GCN-LABEL: name: select_ssv
+# GCN: [[SGPR0:%[0-9]+]]:sgpr(s32) = COPY $sgpr0
+# GCN: [[SGPR1:%[0-9]+]]:sgpr(s32) = COPY $sgpr1
+# GCN: [[SGPR2:%[0-9]+]]:sgpr(s32) = COPY $sgpr2
+# GCN: [[VGPR0:%[0-9]+]]:vgpr(s32) = COPY $vgpr0
+# GCN: [[SCC:%[0-9]+]]:scc(s1) = G_ICMP intpred(ne), [[SGPR0]](s32), [[SGPR1]]
+# GCN: [[SCC_S:%[0-9]+]]:sgpr(s1) = COPY [[SCC]]
+# FAST:   [[SGPR2_V:%[0-9]+]]:vgpr(s32) = COPY [[SGPR2]]
+# FAST:   {{%[0-9]+}}:vgpr(s32) = G_SELECT [[SCC_S]](s1), [[SGPR2_V]], [[VGPR0]]
+# GREEDY: {{%[0-9]+}}:vgpr(s32) = G_SELECT [[SCC_S]](s1), [[SGPR2]], [[VGPR0]]
+
+body: |
+  bb.0:
+    liveins: $sgpr0, $sgpr1, $sgpr2, $vgpr0
+    %0:_(s32) = COPY $sgpr0
+    %1:_(s32) = COPY $sgpr1
+    %2:_(s32) = COPY $sgpr2 
+    %3:_(s32) = COPY $vgpr0
+    %4:_(s1) = G_ICMP intpred(ne), %0, %1
+    %5:_(s32) = G_SELECT %4, %2, %3
+
+...
+
+---
+name: select_svs
+legalized: true
+
+# GCN-LABEL: name: select_svs
+# GCN: [[SGPR0:%[0-9]+]]:sgpr(s32) = COPY $sgpr0
+# GCN: [[SGPR1:%[0-9]+]]:sgpr(s32) = COPY $sgpr1
+# GCN: [[SGPR2:%[0-9]+]]:sgpr(s32) = COPY $sgpr2
+# GCN: [[VGPR0:%[0-9]+]]:vgpr(s32) = COPY $vgpr0
+# GCN: [[SCC:%[0-9]+]]:scc(s1) = G_ICMP intpred(ne), [[SGPR0]](s32), [[SGPR1]]
+# GCN: [[SCC_S:%[0-9]+]]:sgpr(s1) = COPY [[SCC]]
+# FAST:   [[SGPR2_V:%[0-9]+]]:vgpr(s32) = COPY [[SGPR2]]
+# FAST:   {{%[0-9]+}}:vgpr(s32) = G_SELECT [[SCC_S]](s1), [[VGPR0]], [[SGPR2_V]]
+# GREEDY: {{%[0-9]+}}:vgpr(s32) = G_SELECT [[SCC_S]](s1), [[VGPR0]], [[SGPR2]]
+
+body: |
+  bb.0:
+    liveins: $sgpr0, $sgpr1, $sgpr2, $vgpr0
+    %0:_(s32) = COPY $sgpr0
+    %1:_(s32) = COPY $sgpr1
+    %2:_(s32) = COPY $sgpr2
+    %3:_(s32) = COPY $vgpr0
+    %4:_(s1) = G_ICMP intpred(ne), %0, %1
+    %5:_(s32) = G_SELECT %4, %3, %2
+...
+
+---
+name: select_svv
+legalized: true
+
+# GCN-LABEL: name: select_svv
+# GCN: [[SGPR0:%[0-9]+]]:sgpr(s32) = COPY $sgpr0
+# GCN: [[SGPR1:%[0-9]+]]:sgpr(s32) = COPY $sgpr1
+# GCN: [[VGPR0:%[0-9]+]]:vgpr(s32) = COPY $vgpr0
+# GCN: [[VGPR1:%[0-9]+]]:vgpr(s32) = COPY $vgpr1
+# GCN: [[SCC:%[0-9]+]]:scc(s1) = G_ICMP intpred(ne), [[SGPR0]](s32), [[SGPR1]]
+# GCN: [[SCC_S:%[0-9]+]]:sgpr(s1) = COPY [[SCC]]
+# GCN: {{%[0-9]+}}:vgpr(s32) = G_SELECT [[SCC_S]](s1), [[VGPR0]], [[VGPR1]]
+
+body: |
+  bb.0:
+    liveins: $sgpr0, $sgpr1, $vgpr0, $vgpr1
+    %0:_(s32) = COPY $sgpr0
+    %1:_(s32) = COPY $sgpr1
+    %2:_(s32) = COPY $vgpr0
+    %3:_(s32) = COPY $vgpr1
+    %4:_(s1) = G_ICMP intpred(ne), %0, %1
+    %5:_(s32) = G_SELECT %4, %2, %3
+...
+
+---
+name: select_vss
+legalized: true
+
+# GCN-LABEL: name: select_vss
+# GCN:  [[SGPR0:%[0-9]+]]:sgpr(s32) = COPY $sgpr0
+# GCN:  [[SGPR1:%[0-9]+]]:sgpr(s32) = COPY $sgpr1
+# GCN:  [[VGPR0:%[0-9]+]]:vgpr(s32) = COPY $vgpr0
+# GCN:  [[VGPR1:%[0-9]+]]:vgpr(s32) = COPY $vgpr1
+# GCN:  [[VCC:%[0-9]+]]:sgpr(s1) = G_ICMP intpred(ne), [[VGPR0]](s32), [[VGPR1]]
+# FAST:  [[SGPR0_V:%[0-9]+]]:vgpr(s32) = COPY [[SGPR0]]
+# GCN:  [[SGPR1_V:%[0-9]+]]:vgpr(s32) = COPY [[SGPR1]]
+# FAST:  {{%[0-9]+}}:vgpr(s32) = G_SELECT [[VCC]](s1), [[SGPR0_V]], [[SGPR1_V]]
+# GREDY: {{%[0-9]+}}:vgpr(s32) = G_SELECT [[VCC]](s1), [[SGPR0]], [[SGPR1_V]]
+
+body: |
+  bb.0:
+    liveins: $sgpr0, $sgpr1, $vgpr0, $vgpr1
+    %0:_(s32) = COPY $sgpr0
+    %1:_(s32) = COPY $sgpr1
+    %2:_(s32) = COPY $vgpr0
+    %3:_(s32) = COPY $vgpr1
+    %4:_(s1) = G_ICMP intpred(ne), %2, %3
+    %5:_(s32) = G_SELECT %4, %0, %1
+...
+
+---
+name: select_vsv
+legalized: true
+
+# GCN-LABEL: name: select_vsv
+# GCN:  [[SGPR0:%[0-9]+]]:sgpr(s32) = COPY $sgpr0
+# GCN:  [[VGPR0:%[0-9]+]]:vgpr(s32) = COPY $vgpr0
+# GCN:  [[VGPR1:%[0-9]+]]:vgpr(s32) = COPY $vgpr1
+# GCN:  [[VGPR2:%[0-9]+]]:vgpr(s32) = COPY $vgpr2
+# GCN:  [[VCC:%[0-9]+]]:sgpr(s1) = G_ICMP intpred(ne), [[VGPR0]](s32), [[VGPR1]]
+# FAST:   [[SGPR0_V:%[0-9]+]]:vgpr(s32) = COPY [[SGPR0]]
+# FAST:   {{%[0-9]+}}:vgpr(s32) = G_SELECT [[VCC]](s1), [[SGPR0_V]], [[VGPR2]]
+# GREEDY: {{%[0-9]+}}:vgpr(s32) = G_SELECT [[VCC]](s1), [[SGPR0]], [[VGPR2]]
+
+body: |
+  bb.0:
+    liveins: $sgpr0, $vgpr0, $vgpr1, $vgpr2
+    %0:_(s32) = COPY $sgpr0
+    %1:_(s32) = COPY $vgpr0
+    %2:_(s32) = COPY $vgpr1
+    %3:_(s32) = COPY $vgpr2
+    %4:_(s1) = G_ICMP intpred(ne), %1, %2
+    %5:_(s32) = G_SELECT %4, %0, %3
+...
+
+---
+name: select_vvs
+legalized: true
+
+# GCN-LABEL: name: select_vvs
+# GCN:  [[SGPR0:%[0-9]+]]:sgpr(s32) = COPY $sgpr0
+# GCN:  [[VGPR0:%[0-9]+]]:vgpr(s32) = COPY $vgpr0
+# GCN:  [[VGPR1:%[0-9]+]]:vgpr(s32) = COPY $vgpr1
+# GCN:  [[VGPR2:%[0-9]+]]:vgpr(s32) = COPY $vgpr2
+# GCN:  [[VCC:%[0-9]+]]:sgpr(s1) = G_ICMP intpred(ne), [[VGPR0]](s32), [[VGPR1]]
+# FAST:   [[SGPR0_V:%[0-9]+]]:vgpr(s32) = COPY [[SGPR0]]
+# FAST:   {{%[0-9]+}}:vgpr(s32) = G_SELECT [[VCC]](s1), [[VGPR2]], [[SGPR0_V]]
+# GREEDY: {{%[0-9]+}}:vgpr(s32) = G_SELECT [[VCC]](s1), [[VGPR2]], [[SGPR0]]
+
+body: |
+  bb.0:
+    liveins: $sgpr0, $vgpr0, $vgpr1, $vgpr2
+    %0:_(s32) = COPY $sgpr0
+    %1:_(s32) = COPY $vgpr0
+    %2:_(s32) = COPY $vgpr1
+    %3:_(s32) = COPY $vgpr2
+    %4:_(s1) = G_ICMP intpred(ne), %1, %2
+    %5:_(s32) = G_SELECT %4, %3, %0
+...
+
+---
+name: select_vvv
+legalized: true
+
+# GCN-LABEL: name: select_vvv
+# GCN: [[VGPR0:%[0-9]+]]:vgpr(s32) = COPY $vgpr0
+# GCN: [[VGPR1:%[0-9]+]]:vgpr(s32) = COPY $vgpr1
+# GCN: [[VGPR2:%[0-9]+]]:vgpr(s32) = COPY $vgpr2
+# GCN: [[VGPR3:%[0-9]+]]:vgpr(s32) = COPY $vgpr3
+# GCN: [[VCC:%[0-9]+]]:sgpr(s1) = G_ICMP intpred(ne), [[VGPR0]](s32), [[VGPR1]]
+# GCN: {{%[0-9]+}}:vgpr(s32) = G_SELECT [[VCC]](s1), [[VGPR2]], [[VGPR3]]
+
+body: |
+  bb.0:
+    liveins: $vgpr0, $vgpr1, $vgpr2, $vgpr3
+    %0:_(s32) = COPY $vgpr0
+    %1:_(s32) = COPY $vgpr1
+    %2:_(s32) = COPY $vgpr2
+    %3:_(s32) = COPY $vgpr3
+    %4:_(s1) = G_ICMP intpred(ne), %0, %1
+    %5:_(s32) = G_SELECT %4, %2, %3
+...




More information about the llvm-commits mailing list