[PATCH] D51248: Support for remapping profile data, for sample-based profiling.

[Wei Mi via Phabricator via llvm-commits]

wmi accepted this revision.
wmi added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: lib/ProfileData/SampleProfReader.cpp:830
 
+std::error_code SampleProfileReaderItaniumRemapper::read() {
+  // If the underlying data is in compact format, we can't remap it because
----------------
Nit: SampleProfileReaderItaniumRemapper assumes the underlying reader has already read in the profile. The override function read() here is a little misleading that people may think SampleProfileReaderItaniumRemapper can both read in the profile and do the remapping. May be just rename it as remap()?


Repository:
  rL LLVM

https://reviews.llvm.org/D51248