[PATCH] D51353: [PowerPC] Optimize compares fed by ANDISo

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 31 05:59:06 PDT 2018


nemanjai added a comment.

In https://reviews.llvm.org/D51353#1220682, @inouehrs wrote:

> LGTM with nitpicking.
>
> I feel that the current test case is somewhat fragile for minor change in inst. scheduling or register allocation.
>  Checking there is no `cmpdi` between `andis.` and `isel` may be enough.


Yeah, I usually don't like to modify the checks produced by the automated tool. However, I think your suggestion is reasonable - having the `andis.` and no `cmp` before its use should sufficiently test this patch.


Repository:
  rL LLVM

https://reviews.llvm.org/D51353





More information about the llvm-commits mailing list