[PATCH] D51365: [llvm-objdump] Keep the memory buffer from the dSYM alive when using -g -dsym

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 31 05:30:54 PDT 2018


JDevlieghere added a comment.

Looks good!



================
Comment at: test/tools/llvm-objdump/X86/macho-disassembly-g-dsym.test:1
+// RUN: dsymutil -f -oso-prepend-path=%p/../../dsymutil/ %p/../../dsymutil/Inputs/basic.macho.x86_64 -o %t1
+// RUN: llvm-objdump -d -g -dsym=%t1 %p/../../dsymutil/Inputs/basic.macho.x86_64 | FileCheck %s
----------------
nit: I'd probably name this `%t.dSYM`, makes it a little easier to figure out the path if the test ever fails. 


https://reviews.llvm.org/D51365





More information about the llvm-commits mailing list