[PATCH] D51450: [MinGW] [ARM] Add stubs for potential automatic dllimported variables

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: lib/Target/ARM/ARMAsmPrinter.cpp:840
+        StubSym = MachineModuleInfoImpl::StubValueTy(getSymbol(GV),
+                                                     !GV->hasInternalLinkage());
+    }
----------------
rnk wrote:
> Maybe we should just pass `true` here instead of `!GV->hasInternalLinkage()`. We should never use .refptr stubs to access internal symbols, right? They will always be DSO local, and should be accessible with other means.
> 
> We don't even use `Stub.second.getInt()` in the generic AsmPrinter.cpp code that emits the stub globals.
Sounds good; I'll change it similarly in the existing codepath for X86 as well.


Repository:
  rL LLVM

https://reviews.llvm.org/D51450