[PATCH] D51522: [LLVM-C] Add more debug information accessors to GlobalObject and Instruction

whitequark via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 30 22:17:34 PDT 2018


whitequark added inline comments.


================
Comment at: include/llvm-c/Core.h:2150
+ */
+void LLVMGlobalClearMetadata(LLVMValueRef Glob);
+
----------------
CodaFi wrote:
> whitequark wrote:
> > Very small nit: `Global`. There's some code out there that generates a higher level API by parsing the C headers and inferring semantics from names, let's keep it easy to maintain.
> I wanted to distinguish these from their unnamedspaced counterparts that seem to work exclusively with the parallel APIs in llvm::Instruction.  Is there some middle ground naming scheme here or should I remove the Global bits and add GlobalObject support to the Instruction one?
Oh I just mean the argument name.


Repository:
  rL LLVM

https://reviews.llvm.org/D51522





More information about the llvm-commits mailing list