[PATCH] D51524: [ARM64] [Windows] Handle funclets

[Sanjin Sijaric via Phabricator via llvm-commits]

ssijaric added inline comments.


================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:910
+static bool isFuncletReturnInstr(MachineInstr &MI) {
+  switch (MI.getOpcode()) {
+  case AArch64::CATCHRET:
----------------
mgrang wrote:
> default should be the first case.
Will change it in the updated patch.


================
Comment at: lib/Target/AArch64/AArch64InstrInfo.cpp:1606
+    // Skip to the first instruction before the epilog.
+    const TargetInstrInfo *TII = MBB.getParent()->getSubtarget().getInstrInfo();
+    MachineBasicBlock *TargetMBB = MI.getOperand(0).getMBB();
----------------
mgrang wrote:
> Can you move "MBB.getParent()-" to the next line so that it's more readable?
Will do in the updated patch.


================
Comment at: test/CodeGen/AArch64/wineh-funclets.ll:1
+; RUN: llc -o - %s -mtriple=aarch64-windows -stop-after=prologepilog | FileCheck %s
+; This test case just checks that we can get past catchret, etc, and not the
----------------
mgrang wrote:
> Check 80 char limits here.
Is the 80 char limit on the RUN line a rule?  If so, many test cases don't follow this.  A single RUN is not split into multiple lines from what I've seen.


Repository:
  rL LLVM

https://reviews.llvm.org/D51524