[PATCH] D51456: [LLD] [COFF] When doing automatic dll imports, replace whole .refptr.<var> chunks with __imp_<var>

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: COFF/Chunks.h:189
 
+  void discard() { Live = false; }
+
----------------
ruiu wrote:
> mstorsjo wrote:
> > ruiu wrote:
> > > Now `Live` member has both read and write accessors, so I'd make it a public member and remove this function and `isLive`.
> > Ok - what about the `markLive` function, should I remove that one as well? Or do we want to keep it for the sake of the asserts?
> Looks like the only use of `markLive` is in MarkLive.cpp, and if you remove that function and inline it, it is obvious that you don't really need these asserts. So, yes, we should remove `markLive` function.
Sorry, I missed this comment, as it was added right before I updated the diff yesterday.

Will remove that method as well, and commit this.


https://reviews.llvm.org/D51456