[PATCH] D51081: [DWARF v5] Refactoring range list dumping to fold DWARF v4 functionality into v5 handling (almost NFC).

Wolfgang Pieb via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 30 16:59:40 PDT 2018


wolfgangp added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFContext.cpp:285
+      // continue to read the section.
+      if (Offset == 0)
         break;
----------------
Here we're no longer accessing the table length.


================
Comment at: lib/DebugInfo/DWARF/DWARFListTable.cpp:45
+  if (TableLength < sizeof(Header)) {
+    *OffsetPtr = End;
+    return createStringError(
----------------
This indicates a recoverable error and the caller can continue with a presumably correct Offset.


https://reviews.llvm.org/D51081





More information about the llvm-commits mailing list