[PATCH] D51518: [WebAssembly] Add missing SIMD instruction attributes

[Thomas Lively via Phabricator via llvm-commits]

tlively added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:29
 multiclass SIMDLoad<ValueType vec_t> {
-  let mayLoad = 1 in
+  let mayLoad = 1, isAsCheapAsAMove = 1 in
   defm LOAD_#vec_t :
----------------
dschuff wrote:
> I don't think loads and stores are really as cheap as a move (I think "move" means the RISC definition of a move, i.e. "not also a load"). Also wasm loads and stores are potentially more expensive than x86 loads and stores anyway if bounds checking is not free.
You're right, I think I got these loads and stores mixed up with set_local/get_local.


Repository:
  rL LLVM

https://reviews.llvm.org/D51518