[PATCH] D51128: [ORC] LLJITTest: API test and usage examples with actual codegen

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 30 14:16:31 PDT 2018


lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.

This looks great! Thanks Stefan!

The thread / LLVMContext creation code is awkward, but I think that's because ORC isn't really helping yet. I was thinking I might add an ExecutionSession::createCompileThread(...) utility to spawn a thread, provide a portable id that could be used for registering LLVMContexts, provide portable thread teardown, etc. This seems like a good example to apply the idea to to see if it simplifies things.


Repository:
  rL LLVM

https://reviews.llvm.org/D51128





More information about the llvm-commits mailing list