[PATCH] D50845: [CUDA/OpenMP] Define only some host macros during device compilation

Jonas Hahnfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 30 11:38:21 PDT 2018


Hahnfeld added a comment.

In https://reviews.llvm.org/D50845#1219726, @gtbercea wrote:

> In general, it looks like this patch leads to some host macros having to be defined again for the auxiliary triple case. It is not clear to me how to exhaustively identify the missing macros, so far it's been just trial and error.


Well, that's the point of this patch, isn't it? Again, the current approach is to just define all macros which is definitely broken.


Repository:
  rL LLVM

https://reviews.llvm.org/D50845





More information about the llvm-commits mailing list